Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpart0: stdenv.lib -> lib #109376

Merged
merged 1 commit into from Jan 14, 2021
Merged

nixpart0: stdenv.lib -> lib #109376

merged 1 commit into from Jan 14, 2021

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jan 14, 2021

Motivation for this change

This fixes an evaluation error introduced by #108978:

error: --- TypeError ------------------------------------------------------------------------------------------------------------------------- nix
at: (12:12) in file: /nix/store/d6ydr6nsv9hra4ncdgpmg6x16744sb3m-source/pkgs/tools/filesystems/nixpart/0.4/default.nix

    11| let
    12|   blivet = import ./blivet.nix {
      |            ^
    13|     inherit stdenv fetchurl buildPythonApplication;

anonymous function at /nix/store/d6ydr6nsv9hra4ncdgpmg6x16744sb3m-source/pkgs/tools/filesystems/nixpart/0.4/blivet.nix:3:1 called without required argument 'lib'

The package currently can't be build for either python3 because it's disabled or python2 because pycurl doesn't support python2anymore.

$ nix build -f . python3Packages.nixpart0
error: --- ThrownError -------------------------------------------------------------------------- nix
nixpart-0.4.1 not supported for interpreter python3.8

$ nix build -f . pythonPackages.nixpart0
error: --- ThrownError -------------------------------------------------------------------------- nix
pycurl-7.43.0.6 not supported for interpreter python2.7

Despite the fact this package can't be build, I replaced all the remaining stdenv.lib references.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@B4dM4n
nixpart0: stdenv.lib -> lib
f213aa3 
This fixes an evaluation error indroduced by NixOS#108978
SuperSandro2000
SuperSandro2000 approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged when ofborg is done

@SuperSandro2000 SuperSandro2000 merged commit cbadccb into NixOS:master Jan 14, 2021
@B4dM4n B4dM4n deleted the nixpart0-eval-error branch January 14, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @SuperSandro2000 @jonringer