Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/drbd: fix syntax for etc config file and systemd service #109406

Closed
wants to merge 2 commits into from
Closed

nixos/drbd: fix syntax for etc config file and systemd service #109406

wants to merge 2 commits into from

Conversation

jslight90
Copy link
Contributor

Motivation for this change

Fix typo that causes DRBD module to raise an error when enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use this module? I wonder how long this has been broken for... Any interest in writing a NixOS test?

@jslight90
Copy link
Contributor Author

jslight90 commented Jan 15, 2021 •
edited

Do you use this module?

I just started trying to use it for an HA SAN. There are some quirks to the pkg too. Version 8 is not compatible with Linux kernel 5.x; I had to set boot.kernelPackages = pkgs.linuxPackages_4_19. I tried to compile version 9 with nix, but it's going to take more work; the build stage looks for the kernel src directory, which isn't in the nix-store.

I wonder how long this has been broken for...

It looks like the breaking change happened about one year ago: 1d61efb#diff-168f1268fc04de9bceed6749379d94d8c5d45c3aeb9780ae3337851cbd6b603f

@jslight90
Copy link
Contributor Author

It looks like there are more things broken with this than I first thought. The systemd service is not configured correctly and calls the ExecStop command immediately after running the start script.

@aanderse
Copy link
Member

I don't know if would be able find some time dig into this. My experience with drbd isn't that advanced, and isn't on NixOS at all. Are you considering digging deeper into this?

@jslight90 jslight90 changed the title nixos/drbd: fix syntax for etc config file nixos/drbd: fix syntax for etc config file and systemd service Jan 15, 2021
@jslight90
Copy link
Contributor Author

The second commit I just made fixes the systemd service. I might try to work on getting version 9 to compile (there are some nice new features), but I think this pull request works to fix version 8 for now.

@aanderse
Copy link
Member

Thanks again for your work on this @jslight90. Unfortunately I still haven't found time to test this out... but really the module seems pretty broken so I don't think this PR has any possibility to make things worse 😆 From simple inspection of the change everything makes sense, so I'll go ahead and merge this if you're good with that... yes?

@jslight90
Copy link
Contributor Author

Closing in favor of #119904.

@jslight90 jslight90 closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jslight90 @aanderse