Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse: 0.11.1 -> 0.12.1 #109358

Merged
merged 1 commit into from Jan 14, 2021
Merged

reuse: 0.11.1 -> 0.12.1 #109358

merged 1 commit into from Jan 14, 2021

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jan 14, 2021

Motivation for this change

Next to the version bump, the tests are now executed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi
reuse: 0.11.1 -> 0.12.1
8f81d75 
Next to the version bump, the tests are now executed.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109358 run on x86_64-linux 1

1 package built:
  • reuse

@SuperSandro2000 SuperSandro2000 merged commit 55ebc2e into NixOS:master Jan 14, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109358 run on x86_64-darwin 1

1 package built:
  • reuse

@oxzi oxzi deleted the reuse-0.12.1 branch January 14, 2021 15:26
@FlorianFranzen
Copy link
Contributor

Thanks, especially for enabling the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @SuperSandro2000 @FlorianFranzen