Skip to content

python3Packages.mpd2: 3.0.1 -> 3.0.2 #109350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2021
Merged

python3Packages.mpd2: 3.0.1 -> 3.0.2 #109350

merged 1 commit into from
Jan 14, 2021
+2 −2

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes problems in the async implementation.

https://github.com/Mic92/python-mpd2/blob/master/doc/changes.rst#changes-in-v302

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested review from Mic92 and rvl January 14, 2021 09:40
@Mic92 Mic92 merged commit 50fb327 into NixOS:master Jan 14, 2021
@mweinelt mweinelt deleted the mpd2 branch January 14, 2021 10:09
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109350 run on x86_64-linux 1

11 packages built:
  • beets
  • mpdris2
  • poezio (python38Packages.poezio)
  • python37Packages.mpd2
  • python37Packages.poezio
  • python38Packages.mpd2
  • python39Packages.mpd2
  • python39Packages.poezio
  • qtile
  • rofi-mpd
  • sonata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

@Mic92 Mic92

@rvl rvl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @Mic92