Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrangler: 1.12.3 -> 1.13.0 #109402

Merged
merged 1 commit into from Jan 18, 2021
Merged

wrangler: 1.12.3 -> 1.13.0 #109402

merged 1 commit into from Jan 18, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 14, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Br1ght0ne January 14, 2021 20:47
@bbigras
Copy link
Contributor Author

bbigras commented Jan 15, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 15, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 15, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Br1ght0ne
Br1ght0ne approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, binary tested on NixOS.

@Br1ght0ne Br1ght0ne merged commit 3f2e2e1 into NixOS:master Jan 18, 2021
@bbigras bbigras deleted the wrangler branch January 18, 2021 14:30
@bbigras
Copy link
Contributor Author

bbigras commented Jan 18, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @Br1ght0ne