networking-ts-cxx: init at 2019-02-27 #109412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Although this entire package is actually included in the asio library, which is already present in Nixpkgs, there is a valid reason for introducing it as a standalone package:
The headers implement a proposed C++ standard for networking. asio in fact provides these interfaces, but namespaced under asio, which leaks implementation details. Until this issue is resolved, we are best off using this generated code as it's unclear how to get asio to export the exact interface from the standard ourselves.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)