Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.clock-override: init at 12 #109363

Merged
merged 1 commit into from Jan 15, 2021
Merged

gnomeExtensions.clock-override: init at 12 #109363

merged 1 commit into from Jan 15, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add support for GNOME extension Clock Override

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109363 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.clock-override

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not see anything problematic in the PR or in the source code of the extension itself but did not test if the package actually works.

@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Jan 14, 2021

Do not see anything problematic in the PR or in the source code of the extension itself but did not test if the package actually works.

Works if enabled

image

@jtojnar
Copy link
Contributor

jtojnar commented Jan 14, 2021

Do the preferences started from the Extensions app work as well?

@rhoriguchi
Copy link
Contributor Author

Do you mean this menu?

image

I haven't tested it, because I couldn't figure out how to open it.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 15, 2021

Yes, I mean that one.

If you open Extensions app (gnome-shell-extension-prefs) in GNOME, you should see a settings button next to the extension.

It should open and no errors should be logged into system journal (journalctl -xeaf).

@rhoriguchi
Copy link
Contributor Author

Works with no issues

image

@jtojnar jtojnar merged commit bfb91bc into NixOS:master Jan 15, 2021
@jtojnar
Copy link
Contributor

jtojnar commented Jan 15, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants