Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.diskcache: 4.1.0 -> 5.1.0 #109362

Merged
merged 1 commit into from Jan 24, 2021
Merged

python3Packages.diskcache: 4.1.0 -> 5.1.0 #109362

merged 1 commit into from Jan 24, 2021

Conversation

teh
Copy link
Contributor

@teh teh commented Jan 14, 2021

Motivation for this change

update + unbreak on python3.8+

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc January 14, 2021 14:10
SuperSandro2000
SuperSandro2000 reviewed Jan 14, 2021
View reviewed changes
pkgs/development/python-modules/diskcache/default.nix Outdated
@@ -28,8 +28,6 @@ buildPythonPackage rec {
mock
];

disabled = lib.versionAtLeast django.version "2.0";

checkPhase = ''
pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch to pytestCheckHook.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (I think). Tests pass + dependencies still work.

@fabaff
Copy link
Member

fabaff commented Jan 14, 2021

Result of nixpkgs-review pr 109362 run on x86_64-linux 1

5 packages built:
  • python37Packages.diskcache
  • python37Packages.slicedimage
  • python38Packages.diskcache
  • python38Packages.slicedimage
  • python39Packages.diskcache

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109362 run on x86_64-linux 1

5 packages built:
  • python37Packages.diskcache
  • python37Packages.slicedimage
  • python38Packages.diskcache
  • python38Packages.slicedimage
  • python39Packages.diskcache

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109362 run on x86_64-darwin 1

5 packages failed to build and are new build failures:

@teh teh force-pushed the disccache branch 2 times, most recently from 61f8174 to 2811a57 Compare January 14, 2021 23:56
@teh
Copy link
Contributor Author

teh commented Jan 15, 2021

I don't have darwin to test but �[1m�[31mE PermissionError: [Errno 1] Operation not permitted: '/usr/share/zoneinfo'�[0m looks system specific.

I can disable tests on darwin maybe?

@SuperSandro2000
Copy link
Member

I don't have darwin to test but �[1m�[31mE PermissionError: [Errno 1] Operation not permitted: '/usr/share/zoneinfo'�[0m looks system specific.

This is an issue with the darwin sandbox.

I can disable tests on darwin maybe?

Yeah sure, go ahead.

SuperSandro2000
SuperSandro2000 reviewed Jan 15, 2021
View reviewed changes
pkgs/development/python-modules/diskcache/default.nix Outdated
@@ -1,7 +1,7 @@
{ lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib
{ stdenv
, lib

@SuperSandro2000
Copy link
Member

@teh please fix the merge conflict.

@fabaff
Copy link
Member

fabaff commented Jan 23, 2021

FYI: 5.2.1 (https://github.com/grantjenks/python-diskcache/releases/tag/v5.2.1) was released

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109362 run on x86_64-linux 1

5 packages built:
  • python37Packages.diskcache
  • python37Packages.slicedimage
  • python38Packages.diskcache
  • python38Packages.slicedimage
  • python39Packages.diskcache

@SuperSandro2000 SuperSandro2000 merged commit 5c38ea7 into NixOS:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teh @fabaff @SuperSandro2000