ffmpeg-full: disable rav1e by default (in favor of svt-av1) #109405
Merged
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since c378a33 we have a patch to add svt-av1 support to ffmpeg-full. The default AV1 encoder is still libaom but svt-av1 has a higher priority than rav1e (see libavcodec/allcodecs.c). And since svt-av1 is much faster than rav1e (which in turn should be faster than libaom) we don't really need rav1e support by default anymore (I guess it can be useful but overall svt-av1 should currently be the best option). And because rav1e's build did break a few times in the past and needs a lot of Rust dependencies (including cargo-c to make it C-ABI compatible) it might be best to simply disable it for now. Benchmarks (though it is difficult to compare them that way): - https://openbenchmarking.org/test/pts/svt-av1 - https://openbenchmarking.org/test/pts/rav1e - https://openbenchmarking.org/test/pts/aom-av1
I've merged my local package definitions with the ones in Nixpkgs.
primeos
force-pushed
the
ffmpeg-full-disable-rav1e
branch
from
b142a60 to
2345e37
Compare
|
Let's see how this goes then. We can easily re-enable it in case anyone will miss the rav1e support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c378a33 we have a patch to add svt-av1 support to
ffmpeg-full. The default AV1 encoder is still libaom but svt-av1 has a
higher priority than rav1e (see libavcodec/allcodecs.c). And since
svt-av1 is much faster than rav1e (which in turn should be faster than
libaom) we don't really need rav1e support by default anymore (I guess
it can be useful but overall svt-av1 should currently be the best
option).
And because rav1e's build did break a few times in the past and needs a
lot of Rust dependencies (including cargo-c to make it C-ABI
compatible) it might be best to simply disable it for now.
Benchmarks (though it is difficult to compare them that way):
Motivation for this change
@chiiruno (svt-av1), @codyopel (ffmpeg-full): Any opinions/objections?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)