New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana: 7.3.6 -> 7.3.7 #109377
grafana: 7.3.6 -> 7.3.7 #109377
Conversation
Can you explain to me why this needs a port to stable? |
@GrahamcOfBorg test grafana |
If there's no breaking changes, and just bug fixes, I'm fine with backporting a package |
@SuperSandro2000 Yes, as @jonringer wrote, this is just a patch release with bug fixes, so it should be backported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
@ajs124 Asking questions is allowed? |
We only backport a very small set of updates so I just wanted to ask if there is any particularly reason. |
Probably a better way to word this is, "We don't backport breaking changes, unless there's security reasons". Most updates don't get backported because backporting is additional work, and most active contributors just live on unstable. |
I strongly disagree: I don't see a particular reason why people would have to choose between a stable NixOS and receiving fixes for the software they use. |
@Ma27 I think you're misinterpreting what I'm trying to say. In other words, a lot more updates could be backported, they just aren't. |
Thanks! Ported to stable as 78a9e8f. |
Motivation for this change
https://github.com/grafana/grafana/releases/tag/v7.3.7
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)