Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: 7.3.6 -> 7.3.7 #109377

Merged
merged 1 commit into from Jan 14, 2021
Merged

grafana: 7.3.6 -> 7.3.7 #109377

merged 1 commit into from Jan 14, 2021

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/grafana/grafana/releases/tag/v7.3.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 14, 2021
@SuperSandro2000
Copy link
Member

Can you explain to me why this needs a port to stable?

@jonringer
Copy link
Contributor

@GrahamcOfBorg test grafana

@jonringer
Copy link
Contributor

If there's no breaking changes, and just bug fixes, I'm fine with backporting a package

@WilliButz
Copy link
Member Author

@SuperSandro2000 Yes, as @jonringer wrote, this is just a patch release with bug fixes, so it should be backported

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@SuperSandro2000
Copy link
Member

@ajs124 Asking questions is allowed?

@SuperSandro2000
Copy link
Member

We only backport a very small set of updates so I just wanted to ask if there is any particularly reason.

@jonringer
Copy link
Contributor

We only backport a very small set of updates so I just wanted to ask if there is any particularly reason.

Probably a better way to word this is, "We don't backport breaking changes, unless there's security reasons".

Most updates don't get backported because backporting is additional work, and most active contributors just live on unstable.

@Ma27
Copy link
Member

Ma27 commented Jan 14, 2021

Most updates don't get backported because backporting is additional work, and most active contributors just live on unstable.

I strongly disagree: I don't see a particular reason why people would have to choose between a stable NixOS and receiving fixes for the software they use.

@jonringer
Copy link
Contributor

@Ma27 I think you're misinterpreting what I'm trying to say.

In other words, a lot more updates could be backported, they just aren't.

@Ma27 Ma27 merged commit 6b3a546 into NixOS:master Jan 14, 2021
@Ma27
Copy link
Member

Ma27 commented Jan 14, 2021

Thanks! Ported to stable as 78a9e8f.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
@WilliButz WilliButz deleted the update/grafana/v7.3.7 branch January 15, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants