Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdu: 2.2.0 -> 2.3.0 #109391

Merged
merged 1 commit into from Jan 14, 2021
Merged

gdu: 2.2.0 -> 2.3.0 #109391

merged 1 commit into from Jan 14, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 14, 2021

https://github.com/dundee/gdu/releases/tag/v2.3.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and fabaff January 14, 2021 19:11
@fabaff
Copy link
Member

fabaff commented Jan 14, 2021

Result of nixpkgs-review pr 109391 run on x86_64-linux 1

1 package built:
  • gdu

fabaff
fabaff approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

...pr-109391/results/gdu/bin]$ ./gdu -v
Version:	 2.3.0

Looks good to me.

@zowoq zowoq merged commit 2299a66 into NixOS:master Jan 14, 2021
@zowoq zowoq deleted the gdu branch January 14, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @fabaff