Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpi-imager: init at 1.5 #109736

Merged
merged 1 commit into from Jan 19, 2021
Merged

rpi-imager: init at 1.5 #109736

merged 1 commit into from Jan 19, 2021

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Jan 18, 2021

Motivation for this change

#108538

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/tools/misc/rpi-imager/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/rpi-imager/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/rpi-imager/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/rpi-imager/default.nix Show resolved Hide resolved
pkgs/tools/misc/rpi-imager/default.nix Show resolved Hide resolved
pkgs/tools/misc/rpi-imager/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109736 run on x86_64-linux 1

1 package built:
  • rpi-imager

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109736 run on x86_64-darwin 1

1 package failed to build and are new build failure:

You can mark it broken on darwin if you don't know how to fix it.

@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 19, 2021

Marked broken on darwin for now. I'll get around fixing it soon when I'm able to test it on a MacBook.

@SuperSandro2000 SuperSandro2000 merged commit dbb7804 into NixOS:master Jan 19, 2021
@ymarkus ymarkus deleted the rpi-imager branch January 19, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymarkus @SuperSandro2000