Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-utils: fix for python2.7 #107415

Closed
wants to merge 1 commit into from
Closed

pythonPackages.python-utils: fix for python2.7 #107415

wants to merge 1 commit into from

Conversation

sternenseemann
Copy link
Member

Motivation for this change

pytest-flakes is not available for python2.7 so we disable tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

When I build python-utils on master I get the following:

$ nix-build -A python27Packages.python-utils
error: pytest-flakes-4.0.3 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)

We might want to drop python 2.7 completely.

@sternenseemann
Copy link
Member Author

Since this is a test only dependency, setting doCheck = false for Python 2.7 prevents nix from evaluating pytest-flakes and thus gets rid of the error for python27Packages.

@r-burns
Copy link
Contributor

r-burns commented Dec 22, 2020

Afaik python2 has been dropped, apart from the few packages that we've been unable to migrate to python3, and hydra doesn't recurse into the python2 set anymore. We probably still accept unintrusive fixes for python2, but just fyi support seems to be long gone

@SuperSandro2000
Copy link
Member

Closing because python 2 support is slowly being removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @SuperSandro2000 @r-burns