New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcitx5-mozc: init at 2.26.4220.102 #109735
Conversation
c99023c
to
609fa83
Compare
Just tried linking the new version abseil-cpp, instead of fetching and compiling it in place. But it brokes. Full build log:
|
Although not sure if it was the right way, dynamic linking abseil-cpp solved this. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based of #110323 (comment) I think it is fine if vendor abseil-cpp.
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
2 packages built:
|
fa57a54
to
7271538
Compare
7271538
to
1a5d1dc
Compare
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package blacklisted:
2 packages built:
|
I've squashed your commits together. |
1a5d1dc
to
e8ffe04
Compare
Motivation for this change
fcitx5-mozc is a Japanese input method engine based on mozc.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)