Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift: fix for pkgsStatic #109769

Merged
merged 1 commit into from Jan 18, 2021
Merged

thrift: fix for pkgsStatic #109769

merged 1 commit into from Jan 18, 2021

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 18, 2021

Motivation for this change

pkgsStatic.flex crashed so I moved flex and bison to nativeBuildInputs, where it should have been in the first place.
Also, building a static lib for python doesn't make a lot of sense, so it is disabled now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bjornfor January 18, 2021 14:25
@Mic92 Mic92 merged commit f29c832 into NixOS:master Jan 18, 2021
@tobim tobim deleted the pkgs/thrift-fix-static branch January 18, 2021 14:50
nativeBuildInputs = [ cmake pkgconfig ];
buildInputs = [ boost zlib libevent openssl python bison flex ]
++ stdenv.lib.optional (!static) twisted;
nativeBuildInputs = [ cmake pkgconfig bison flex ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants