nixos/nomad: enforce specific data_dir semantics #109768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanderse
reviewed
Jan 19, 2021
cpcloud
force-pushed
the
nomad-datadir-cleanup
branch
from
c6ab4a8
to
8b816ba
Compare
added 12 commits
January 23, 2021 19:44
…lation to data_dir
cpcloud
force-pushed
the
nomad-datadir-cleanup
branch
from
ebefd44
to
c7c3b9e
Compare
|
@aanderse Is this okay to merge? |
aanderse
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
LGTM 👍
I'll defer to @lovesegfault for merge, preferably, though. I'm not a nomad user.
|
Roger that! Thanks. |
lovesegfault
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR enforces the semantics discussed here: #105739 (comment)
In summary, the
data_dirvalue of the nomad service must be set toa specific value if
dropPrivilegesis set totrue.The updated unit also includes additional documentation describing
the responsibilities of the nomad cluster manager given these
constraints as well as a suggestion for how to go about satisfying them.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)