Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r-modules: fix clustermq and rzmq build #109706

Merged
merged 1 commit into from Jan 18, 2021
Merged

r-modules: fix clustermq and rzmq build #109706

merged 1 commit into from Jan 18, 2021

Conversation

PhDyellow
Copy link

Motivation for this change

Some R packages from CRAN would not build without these changes.

rzmq now uses pkgconfig.

clustermq now incorporates ZMQ libs directly, rather than using
the rzmq package. clustermq depends on zeromq and pkgconfig.

Both packages need patchShebangs for pkgconfig.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r-modules: fix clustermq and rzmq build
364de6d 
rzmq uses pkgconfig.

clustermq now incorporates ZMQ libs directly, rather than using
the rzmq package. clustermq now uses zeromq and pkgconfig.

Both packages needed patchShebangs, due to pkgconfig.
@PhDyellow PhDyellow requested a review from peti as a code owner January 18, 2021 05:53
@peti peti merged commit 156071b into NixOS:master Jan 18, 2021
@PhDyellow PhDyellow deleted the master_plus_patches_2 branch May 4, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhDyellow @peti