New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "town name" selection into map generator GUI #8566
Conversation
…ee window, and give it the same 'basic' visibility as 'in-game tree placement'.
…ve it the same 'basic' visibilty as 'signal side'.
Easy +1 from me. I did use the 'thumbs up' on the PR, but I don't really trust that as a process yet. |
STR_GAME_OPTIONS_ROAD_VEHICLES_DROPDOWN_LEFT :Drive on left | ||
STR_GAME_OPTIONS_ROAD_VEHICLES_DROPDOWN_RIGHT :Drive on right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the remaining string ids should be renamed, given they're no longer in the game options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that might be a good thing for future-us :D
uint gen = _settings_newgame.game_creation.town_name; | ||
StringID name = gen < BUILTIN_TOWNNAME_GENERATOR_COUNT ? | ||
STR_GAME_OPTIONS_TOWN_NAME_ORIGINAL_ENGLISH + gen : | ||
GetGRFTownNameName(gen - BUILTIN_TOWNNAME_GENERATOR_COUNT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedantry: not sure i agree with the line splitting here. All on one line, or split with the ?
/:
as the first character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#shipit
Motivation / Problem
There have been plenty of attempts to redesign the map generation window. Most get derailed into wanting to change everything.
This PR deals with two "world generation" settings:
Both settings do not belong into "game options". The most reported issue related to NewGRF town names is, that players do not "find" the "town name" dropdown to enable them.
Description
Main change:
Collateral changes:
Limitations
None.
Checklist for review
N/A