Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookstack: init at 0.31.7, nixos/bookstack: init #109711

Merged
merged 2 commits into from Mar 18, 2021
Merged

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Jan 18, 2021

Motivation for this change

BookStack is missing as package and module.

The package was built with composer2nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules do not have a version. Please remove the version from the init commit.

pkgs/servers/web-apps/bookstack/update.sh Show resolved Hide resolved
pkgs/servers/web-apps/bookstack/composer-env.nix Outdated Show resolved Hide resolved
@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 18, 2021

OK, now everything should be fine. Had to fix an error with a missing description.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look over this and left a few notes. I'll need to dig deeper into this.

Have you been running this in a real environment at all, or just playing around with it? I've been wanting to spend some time packaging a laravel app for NixOS so I'm very interested in this PR.

nixos/modules/services/web-apps/bookstack.nix Outdated Show resolved Hide resolved
pkgs/servers/web-apps/bookstack/default.nix Show resolved Hide resolved
@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 19, 2021

I took a quick look over this and left a few notes. I'll need to dig deeper into this.

Have you been running this in a real environment at all, or just playing around with it? I've been wanting to spend some time packaging a laravel app for NixOS so I'm very interested in this PR.

Yes, I've been using this in my staging environment for some days now and it runs fine. The only issue is the bootstrap/cache folder being symlinked throwing errors, so I've left that out for now.

@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 19, 2021

Had to change how the config file is done to make sure the secrets are not in the nix store.

@ymarkus ymarkus marked this pull request as draft January 19, 2021 17:34
@ymarkus ymarkus force-pushed the bookstack branch 3 times, most recently from 279708f to 472f1ea Compare January 20, 2021 15:14
@ymarkus
Copy link
Contributor Author

ymarkus commented Jan 23, 2021

I've changed those few things, should now be ready to merge!

@ymarkus ymarkus marked this pull request as ready for review January 23, 2021 16:44
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What a great module! Fantastic work on this. Full points awarded ✨

I don't review packages, but as long as someone else signs off on this I suggest merge. If @etu is willing his review on the package would be quite valuable since he is familiar with composer2nix.

@ymarkus ymarkus requested a review from etu January 26, 2021 11:24
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/454

@aanderse
Copy link
Member

aanderse commented Feb 1, 2021

/marvin opt-in
/status needs_reviewer

@ymarkus
Copy link
Contributor Author

ymarkus commented Feb 3, 2021

bump to 0.31.5

@ymarkus ymarkus changed the title bookstack: init at 0.31.4, nixos/bookstack: init bookstack: init at 0.31.5, nixos/bookstack: init Feb 3, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109711 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • bookstack

@ymarkus
Copy link
Contributor Author

ymarkus commented Feb 8, 2021

Another version bump to 0.31.6

@ymarkus ymarkus changed the title bookstack: init at 0.31.5, nixos/bookstack: init bookstack: init at 0.31.6, nixos/bookstack: init Feb 8, 2021
@aanderse
Copy link
Member

ping @etu @talyz @Ma27 @jtojnar or anyone who is able to review this package. Any help appreciated if you're able.

@aanderse
Copy link
Member

aanderse commented Mar 6, 2021

@ymarkus I find it terribly regrettable this hasn't been merged yet.
@jonringer is there any advice you can provide us on how to proceed with this PR? We're looking for people to review the package portion, but having terrible finding subject matter experts.

@ymarkus ymarkus changed the title bookstack: init at 0.31.6, nixos/bookstack: init bookstack: init at 0.31.7, nixos/bookstack: init Mar 12, 2021
@ymarkus
Copy link
Contributor Author

ymarkus commented Mar 12, 2021

Version bump to 0.31.7

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't do an indepth review. However, it looks good on the surface level. Hoping someone more familiar with the application can also review it.

@ymarkus
Copy link
Contributor Author

ymarkus commented Mar 15, 2021

Thanks for the reviews. @jonringer I'm not sure if there are a lot of people here with knowledge of bookstack (it's quite young), but I've been using this exact module in production for more than a month now and it's working flawlessly.
@aanderse had great insights to the backend and helped a lot, so I think this should be technically sound.

@aanderse aanderse merged commit 7cdd623 into NixOS:master Mar 18, 2021
@aanderse
Copy link
Member

Thanks for your perseverance on this @ymarkus! Thank you 🎉

@ymarkus
Copy link
Contributor Author

ymarkus commented Mar 18, 2021

No worries. Thanks for your help!

@ymarkus ymarkus deleted the bookstack branch March 18, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants