Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidcheck: unstable-2018-09-27 -> unstable-2020-12-19 #107331

Conversation

tsmanner
Copy link
Contributor

Updated to point at a much newer version of the library. Moving forward before was difficult because of a segfault introduced to rapidcheck when it's static library was optimized or stripped. That was fixed by a commit on 19 December 2020.

Motivation for this change

The rapidcheck library is sitting at a version that is more than two years old. There is functionality that has been added since that time that it would be nice to be able to access without having to override the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Updated to point at a much newer version of the library.  Moving forward before was difficult because of a segfault introduced to rapidcheck when it's static library was optimized or stripped.  That was fixed by a commit on 19 December 2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants