Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 3.9.1 -> 3.9.2 #109759

Merged
merged 1 commit into from Jan 18, 2021
Merged

kustomize: 3.9.1 -> 3.9.2 #109759

merged 1 commit into from Jan 18, 2021

Conversation

ymatsiuk
Copy link
Contributor

@ymatsiuk ymatsiuk commented Jan 18, 2021 •
edited

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymatsiuk
Copy link
Contributor Author

Result of nixpkgs-review pr 109759 run on x86_64-linux 1

1 package built:
  • kustomize

vdemeester
vdemeester approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109759 run on x86_64-darwin 1

1 package built:
  • kustomize

@SuperSandro2000 SuperSandro2000 merged commit 09c12e4 into NixOS:master Jan 18, 2021
@ymatsiuk ymatsiuk deleted the bumpkustomize branch May 3, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@Chili-Man Chili-Man Awaiting requested review from Chili-Man

@zaninime zaninime Awaiting requested review from zaninime

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ymatsiuk @SuperSandro2000 @vdemeester