Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.hxd: init at 0.2.0 #109758

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jan 18, 2021

Motivation for this change

Required for git >= 3.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.hxd

Copy link
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won’t build for OCaml < 4.06.

@sternenseemann
Copy link
Member Author

Reduced propagation and marked minimumOCamlVersion as per opam file.

@vbgl vbgl merged commit 0f864eb into NixOS:master Jan 22, 2021
@sternenseemann sternenseemann deleted the ocaml-hxd-0.2.0 branch January 22, 2021 08:29
@sternenseemann sternenseemann restored the ocaml-hxd-0.2.0 branch July 24, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants