Fix some logging with ca derivations #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thufschmitt
commented
Jan 18, 2021
thufschmitt
commented
- Make the error message for missing outputs more useful
- Fix the error message when a dep is missing
edolstra
reviewed
Jan 18, 2021
src/libstore/store-api.cc
Outdated
| @@ -394,7 +394,7 @@ OutputPathMap Store::queryDerivationOutputMap(const StorePath & path) { | |||
| OutputPathMap result; | |||
| for (auto & [outName, optOutPath] : resp) { | |||
| if (!optOutPath) | |||
| throw Error("output '%s' has no store path mapped to it", outName); | |||
| throw Error("output '%s' of derivation '%s' has no store path mapped to it", outName, path.to_string()); | |||
There was a problem hiding this comment.
Shouldn't this be printStorePath(path)?
Don't only show the name of the output, but also the derivation to which this output belongs (as otherwise it's very hard to track back what went wrong)
Fix a mismatch in the errors thrown when a needed output was missing from an input derivation that was leading to a wrong and quite misleading error message
thufschmitt
force-pushed
the
ca/error-logging-fixes
branch
from
901402e
to
9da11ba
Compare
Ericson2314
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.