Fix: [Actions] Give Universal Mac packages the "universal" suffix #8585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
I updated the macOS release action to generate a universal build, but the .dmg still has the x86_64 suffix.
Description
Rather than manually attempting to rename the .dmg after creation, I have added in a flag to indicate a universal build will be created.
Eventually this flag could perhaps be used to actually include the lipo step (if the path to the existing build is specified, a bit like we do with host build tools).
Limitations
A user creating a universal build currently has to manually glue things together, this flag will not change that. It purely affects the naming.