-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Support --no-modify-profile for daemon installations #4457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support --no-modify-profile for daemon installations #4457
Conversation
TODOs before I unmark as draft:
|
00bbb13
to
7cb3bcf
Compare
Unlike the single user install which edits user-specific files in $HOME the daemon installer only edits global shell startup files. As some systems have non-standard locations for these global files (e.g. usage of `/etc/zsh/zshenv` instead of /etc/zshenv), this allows folks to pre-configure relevant shell startup files before they run the regular installer. Personally, I don't edit the shell (i.e. bash/zsh) specific files, but create a symlink in `/etc/profile.d` directly to $PROFILE_NIX_FILE (instead of a file sourcing it). I also don't need any of the backup functionality.
7cb3bcf
to
0a346b7
Compare
Tested locally with the 2 situations from the TODO, as well as another one with Test Script
Test output
|
Let me know if there's a better way to test this and/or if I should check in the test script - I couldn't find any existing tests for the installer. |
Also, let me know if I should update any release notes (or website documentation?). I didn't see any existing installer docs detailing all the flags to update, and https://github.com/NixOS/nix/blob/master/doc/manual/src/contributing/contributing.md is empty / https://nixos.org/guides/contributing.html doesn't mention if release notes should be updated or not. |
I marked this as stale due to inactivity. → More info |
Does this help make the installer more ideompotent? |
Unlike the single user install which edits user-specific files in $HOME
the daemon installer only edits global shell startup files.
As some systems have non-standard locations for these global files
(e.g. usage of
/etc/zsh/zshenv
instead of /etc/zshenv),this allows folks to pre-configure relevant shell startup files
before they run the regular installer.
Personally, I don't edit the shell (i.e. bash/zsh) specific files,
but create a symlink in
/etc/profile.d
directly to $PROFILE_NIX_FILE(instead of a file sourcing it).
I also don't need any of the backup functionality.
Fixes #4369.