manual: Element: Fix misleading base_url.
#109691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
8.has: module (update)
and removed
8.has: documentation
labels
nh2
force-pushed
the
manual-element-base_url
branch
from
7eb9d9b
to
d48c2e6
Compare
Judging from `"${pkgs.element-web}/config.sample.json"`,
this needs be a URL starting with `https://`; without it one gets:
Your Element is misconfigured
Invalid base_url for m.homeserver
nh2
force-pushed
the
manual-element-base_url
branch
from
d48c2e6
to
b954e0a
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Judging from
"${pkgs.element-web}/config.sample.json", this needs to be anhttps://URL; the same thing you've set for the nginxvirtualHostsentry.With the config without
https://at the front I get from Element when loading it in the browser:(Note the current approach may have been correct in the past, I didn't check that.)
Things done
CC @Ma27 who added the manual entry in commit 849e168.