Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nomad: add extraSettingsPaths option to nomad service #109761

Merged
merged 13 commits into from Jan 23, 2021

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jan 18, 2021

Motivation for this change

Add the ability to use multiple configuration files with the nomad service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

#108411

nixos/modules/services/networking/nomad.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/nomad.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/nomad.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/nomad.nix Outdated Show resolved Hide resolved
nixos/tests/nomad.nix Outdated Show resolved Hide resolved
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 23, 2021

@roberth Is this good to merge?

@roberth roberth changed the title nixos/nomad: add settingsFiles configuration option to nomad service nixos/nomad: add extraSettingsFiles option to nomad service Jan 23, 2021
@roberth roberth changed the title nixos/nomad: add extraSettingsFiles option to nomad service nixos/nomad: add extraSettingsPaths option to nomad service Jan 23, 2021
@roberth roberth merged commit f1778cd into NixOS:master Jan 23, 2021
@roberth
Copy link
Member

roberth commented Jan 23, 2021

Thanks you @cpcloud !

@cpcloud cpcloud deleted the nomad-settings-files branch January 23, 2021 22:59
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 23, 2021

No, thank you for the great review and the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants