Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: unbreak on 20.09 #109716

Merged
merged 5 commits into from Jan 21, 2021
Merged

crystal: unbreak on 20.09 #109716

merged 5 commits into from Jan 21, 2021

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Crystal was broken on 20.09 so backport the fixes from unstable that makes things work again.

Doing a test deployment right with this.

Cc @NixOS/crystal-lang

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build crystal_0_34 crystal_0_31 crystal_0_35

@peterhoeg peterhoeg changed the title crystal: unbreak on 20.09 [WIP] crystal: unbreak on 20.09 Jan 21, 2021
@peterhoeg peterhoeg merged commit 9db4f26 into NixOS:release-20.09 Jan 21, 2021
@peterhoeg peterhoeg deleted the f/crystal_stable branch January 21, 2021 02:22
@fabianhjr fabianhjr removed their request for review January 21, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@david50407 david50407 Awaiting requested review from david50407

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @fabianhjr