Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotifyd: 0.2.24 -> 0.3.0 #109681

Merged
merged 1 commit into from Jan 18, 2021
Merged

spotifyd: 0.2.24 -> 0.3.0 #109681

merged 1 commit into from Jan 18, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 18, 2021

Motivation for this change

https://github.com/Spotifyd/spotifyd/releases/tag/v0.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 merged commit c59e031 into NixOS:master Jan 18, 2021
@bnjmnt4n
Copy link
Contributor

Seems like removing the changes in #106050 (using an older version of Rust to build) causes the same panics until Spotifyd/spotifyd#719 is resolved.

@sarcasticadmin
Copy link
Member

@bnjmnt4n that panic is now fixed in #114309

@andir
Copy link
Member

andir commented Feb 27, 2021

I just saw this and I am a bit stunned. The comment was removed while the issue wasn't fixed. Has either of you (@marsam, @SuperSandro2000) actually tested this on their setup? Checked the upstream issue if it was fixed in this version?

@andir andir mentioned this pull request Feb 27, 2021
Merged
10 tasks
@marsam
Copy link
Contributor Author

marsam commented Mar 1, 2021

@andir I'm so sorry. This was a half-automatized update, I forgot to test it thoroughly. I'll be more careful in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderslundstedt anderslundstedt Awaiting requested review from anderslundstedt

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @bnjmnt4n @sarcasticadmin @andir @SuperSandro2000