Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make road & rail pathfinders account for maximum order speed, if set #8722

Merged
merged 1 commit into from Feb 22, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Feb 22, 2021

Motivation / Problem

Buried in the text & savegame for #8594 was mention of order speed limits. The number of people who know about & use this feature is probably vanishingly small, but it seems proper that the pathfinder should take it into account when calculating the best route.

Description

Set the vehicle's max speed in the pathfinder. I could've set this in GetSpeedLimit in follow_track.hpp, but this seemed otherwise unrelated to the "track".
Order speed for road vehicles doubled because of road veh units (and that's what's done elsewhere)

Limitations

More possible changes to routing behaviour - but if you're using order speed limits, you're already doing some pretty custom stuff.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not. What could possibly go wrong :D

@LordAro LordAro merged commit 80fb1c7 into OpenTTD:master Feb 22, 2021
@LordAro LordAro deleted the pathfinder-order-speed branch February 22, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants