EE: Subsumption Algorithm -- Part 5 #4338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying @hillbrad. (Learn how reviewing works.) |
aubakirova
force-pushed
the
part1.5
branch
2 times, most recently
from
c6c617b
to
9d68d6e
Compare
aubakirova
force-pushed
the
part1.5
branch
2 times, most recently
from
b755efa
to
34cc245
Compare
|
Rebased! |
mikewest
approved these changes
Dec 16, 2016
| { "name" : "Wildcard list subsumes an empty source list.", | ||
| "required_csp": "img-src *", | ||
| "returned_csp_1": "img-src ", | ||
| "returned_csp_2": null, |
|
Oops, this was approved but never merged, probably because of the failing "code-review/reviewable" check. @aubakirova, although there are no conflicts, can you rebase this on master and see if the test still works? That will also trigger another check run, and if it passes we can merge this. |
|
@andypaicu, might you be able to revive this PR? |
|
landed in #27727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for wildcard lists (
*)@mikewest