[Gecko Bug 1675779] HandleDeleteAtomicContent should handle non-editable text node. #27724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `WSScanResult` can return non-editable/non-removable text node, `HandleDeleteAtomicContent` is called with non editable text node, then it cannot remove atomic content. This fix doesn't follow other block case such as added newer test. Differential Revision: https://phabricator.services.mozilla.com/D96298 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1675779 gecko-commit: edd38c6dc831f9e63222ab38ad9ef099c9691506 gecko-reviewers: masayuki
wpt-pr-bot
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WSScanResultcan return non-editable/non-removable text node,HandleDeleteAtomicContentis called with non editable text node, then it cannotremove atomic content.
This fix doesn't follow other block case such as added newer test.
Differential Revision: https://phabricator.services.mozilla.com/D96298
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1675779
gecko-commit: edd38c6dc831f9e63222ab38ad9ef099c9691506
gecko-reviewers: masayuki