Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the "translate" property in SVG. #25928

Merged
merged 1 commit into from Feb 22, 2021

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Oct 1, 2020

This is adding new WebKit layout tests created for WebKit bug 216997.

Copy link
Contributor

@heycam heycam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Other tests that might be worth adding:

  • that translate does the right thing in conjunction with transform-box (I guess transform-origin has no effect on translate, but when you add tests for rotate it will)
  • that an attribute named translate has no effect (there shouldn't be a presentation attribute for it)

Comment on lines +21 to +22


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can drop these blank lines. (And in a couple of the other files added.)

<title>CSS Transforms Test: combination of the CSS translate and transform properties and the SVG transform attribute</title>
<link rel="author" title="Antoine Quint" href="mailto:graouts@apple.com">
<meta name="flags" content="svg">
<style type="text/css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type="text/css on style elements is redundant these days. (And in the other files.)

@gsnedders gsnedders merged commit a906099 into web-platform-tests:master Feb 22, 2021
@gsnedders
Copy link
Member

(Landing this with the nits because an unlanded test with nits is much less useful than a landed test with nits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants