kak-lsp: 8.0.0 -> 9.0.0 #110663

wahjava · 2021-01-24T07:30:50Z

Motivation for this change

Things done

pkgs/applications/editors/kakoune/plugins/kak-lsp.nix

wahjava · 2021-01-24T11:26:53Z

Thanks for pointing to PR #108363. It seems kak-lsp is already part of nixpkgs, just not part of kakounePlugins, where I was expecting it to be present. I will submit a new diff to update existing derivation instead. Should I open a new PR, or overwrite this one ?

SuperSandro2000 · 2021-01-24T15:22:52Z

Should I open a new PR, or overwrite this one ?

Overwriting and changing the title would be fine for me.

wahjava · 2021-01-25T16:27:00Z

Should I open a new PR, or overwrite this one ?

Overwriting and changing the title would be fine for me.

Pushed, thanks!

Flakebi · 2021-01-25T16:51:12Z

Can you reuse the top-level kak-lsp package like it is done for parinfer-rust and rep?

wahjava · 2021-01-26T04:22:40Z

Can you reuse the top-level kak-lsp package like it is done for parinfer-rust and rep?

Sorry, I'm confused. This PR (the latest commit) changes the file pkgs/tools/misc/kak-lsp/default.nix and that file is already referenced in pkgs/top-level/all-packages.nix. If this is not what you expect, then could you please elaborate ?

Thanks!

Flakebi · 2021-01-26T07:58:29Z

The change to pkgs/tools/misc/kak-lsp/default.nix looks good, thanks for the update.

You add the same file again at pkgs/applications/editors/kakoune/plugins/kak-lsp.nix, which is not necessary.
You can add kak-lsp to kakounePlugins with inherit kak-lsp; in the beginning of pkgs/applications/editors/kakoune/plugins/default.nix (just add it to the list of inherit parinfer-rust rep; and to the package inputs in the first line).
inherit pkgname; is equivalent to pkgname = pkgname;: It adds an attribute with the same name as a variable from the current scope.

wahjava · 2021-01-26T17:45:10Z

The change to pkgs/tools/misc/kak-lsp/default.nix looks good, thanks for the update.

You add the same file again at pkgs/applications/editors/kakoune/plugins/kak-lsp.nix, which is not necessary.
You can add kak-lsp to kakounePlugins with inherit kak-lsp; in the beginning of pkgs/applications/editors/kakoune/plugins/default.nix (just add it to the list of inherit parinfer-rust rep; and to the package inputs in the first line).
inherit pkgname; is equivalent to pkgname = pkgname;: It adds an attribute with the same name as a variable from the current scope.

Sorry, I missed the fact that I pushed my commit on the top of existing. Thanks for pointing out. Pushed again, and now there is only one commit containing both changes. Let me know if you like me to split into two commits in this same PR.

Flakebi · 2021-01-26T18:17:32Z

You need to add kak-lsp to the arguments, otherwise it will not be found.

error: --- UndefinedVarError ----------------------------------------------------------------------------------------------------------- nix-env
at: (3:2) in file: /home/sebi/.cache/nixpkgs-review/pr-110663/nixpkgs/pkgs/applications/editors/kakoune/plugins/default.nix

     2|
     3| {
      |  ^
     4|   inherit parinfer-rust rep kak-lsp;

undefined variable 'kak-lsp'

wahjava · 2021-01-26T18:29:19Z

You need to add kak-lsp to the arguments, otherwise it will not be found.

error: --- UndefinedVarError ----------------------------------------------------------------------------------------------------------- nix-env
at: (3:2) in file: /home/sebi/.cache/nixpkgs-review/pr-110663/nixpkgs/pkgs/applications/editors/kakoune/plugins/default.nix

     2|
     3| {
      |  ^
     4|   inherit parinfer-rust rep kak-lsp;

undefined variable 'kak-lsp'

Ofcourse, and sorry, I overlooked that. It now builds fine when referenced with kakounePlugins.kak-lsp.

Thanks!

Flakebi

Thank you!

Result of nixpkgs-review pr 110663 run on x86_64-linux 1

1 package built:

kak-lsp

SuperSandro2000 · 2021-01-26T21:09:08Z

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110663 run on x86_64-darwin 1

1 package built:

kak-lsp

SuperSandro2000 · 2021-01-26T22:44:55Z

pkgs/tools/misc/kak-lsp/default.nix

  };

-  cargoSha256 = "174qy50m9487vv151vm8q6sby79dq3gbqjbz6h4326jwsc9wwi8c";
+  cargoSha256 = "0g67s6n45rxvv1q5s7x5ajh5n16p68bhlsrsjp46qamrraz63d68";

  buildInputs = lib.optional stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ];


Suggested change

buildInputs = lib.optional stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ];

buildInputs = lib.optional stdenv.isDarwin [ Security ];

Please add Security to inputs and inherit it from top level inherit (darwin.apple_sdk.frameworks) Security.

Updated in 35a2887. I'm only able to test this on NixOS, but let me know if this is not how you expected it.

I meant like this a723537

Thanks, updated in 25e2b72. Let me know if you like me to note this change in commit message as well, although I don't know what this change will be described so as to be useful in a commit message.

SuperSandro2000 · 2021-02-17T13:34:56Z

@wahjava please fix the merge conflitct.

While here, also add to kakounePlugins

wahjava · 2021-02-19T14:38:04Z

@wahjava please fix the merge conflitct.

Merged, and forced pushed.

SuperSandro2000 · 2021-02-21T18:34:00Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110663 run on x86_64-darwin 1

1 package built:

kak-lsp

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 24, 2021

SuperSandro2000 reviewed Jan 24, 2021

View reviewed changes

pkgs/applications/editors/kakoune/plugins/kak-lsp.nix Outdated Show resolved Hide resolved

wahjava force-pushed the add-kak-lsp branch from ad5fc59 to f5d1d0d Compare January 24, 2021 11:18

wahjava changed the title ~~kakounePlugins.kak-lsp: init at 9.0.0~~ kak-lsp: 8.0.0 -> 9.0.0 Jan 25, 2021

ofborg bot requested a review from spacekookie January 25, 2021 16:35

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 25, 2021

wahjava force-pushed the add-kak-lsp branch from 420cd8c to 9a1f050 Compare January 26, 2021 17:44

wahjava force-pushed the add-kak-lsp branch from 9a1f050 to 6cbc42e Compare January 26, 2021 17:48

wahjava force-pushed the add-kak-lsp branch from 6cbc42e to f0df04d Compare January 26, 2021 18:27

Flakebi approved these changes Jan 26, 2021

View reviewed changes

SuperSandro2000 reviewed Jan 26, 2021

View reviewed changes

wahjava force-pushed the add-kak-lsp branch 2 times, most recently from 35a2887 to 25e2b72 Compare February 15, 2021 19:15

SuperSandro2000 added the 2.status: merge conflict label Feb 17, 2021

kak-lsp: 8.0.0 -> 9.0.0

81b7b0b

While here, also add to kakounePlugins

wahjava force-pushed the add-kak-lsp branch from 25e2b72 to 81b7b0b Compare February 19, 2021 14:37

ofborg bot removed the 2.status: merge conflict label Feb 19, 2021

SuperSandro2000 merged commit dd630d1 into NixOS:master Feb 21, 2021

wahjava deleted the add-kak-lsp branch February 22, 2021 07:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kak-lsp: 8.0.0 -> 9.0.0 #110663

kak-lsp: 8.0.0 -> 9.0.0 #110663

wahjava commented Jan 24, 2021

wahjava commented Jan 24, 2021

SuperSandro2000 commented Jan 24, 2021

wahjava commented Jan 25, 2021

Flakebi commented Jan 25, 2021

wahjava commented Jan 26, 2021

Flakebi commented Jan 26, 2021

wahjava commented Jan 26, 2021 •

edited

Flakebi commented Jan 26, 2021

wahjava commented Jan 26, 2021

Flakebi left a comment

SuperSandro2000 commented Jan 26, 2021

SuperSandro2000 Jan 26, 2021

wahjava Feb 14, 2021

SuperSandro2000 Feb 14, 2021

wahjava Feb 15, 2021

SuperSandro2000 commented Feb 17, 2021

wahjava commented Feb 19, 2021

SuperSandro2000 commented Feb 21, 2021

	buildInputs = lib.optional stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ];
	buildInputs = lib.optional stdenv.isDarwin [ Security ];

kak-lsp: 8.0.0 -> 9.0.0 #110663

kak-lsp: 8.0.0 -> 9.0.0 #110663

Conversation

wahjava commented Jan 24, 2021

Motivation for this change

Things done

wahjava commented Jan 24, 2021

SuperSandro2000 commented Jan 24, 2021

wahjava commented Jan 25, 2021

Flakebi commented Jan 25, 2021

wahjava commented Jan 26, 2021

Flakebi commented Jan 26, 2021

wahjava commented Jan 26, 2021 • edited

Flakebi commented Jan 26, 2021

wahjava commented Jan 26, 2021

Flakebi left a comment

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 26, 2021

SuperSandro2000 Jan 26, 2021

Choose a reason for hiding this comment

wahjava Feb 14, 2021

Choose a reason for hiding this comment

SuperSandro2000 Feb 14, 2021

Choose a reason for hiding this comment

wahjava Feb 15, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Feb 17, 2021

wahjava commented Feb 19, 2021

SuperSandro2000 commented Feb 21, 2021

wahjava commented Jan 26, 2021 •

edited