Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.umap-learn: 0.4.5 -> 0.5.0 (fix the build) #110688

Merged
merged 3 commits into from Jan 27, 2021
Merged

python3.pkgs.umap-learn: 0.4.5 -> 0.5.0 (fix the build) #110688

merged 3 commits into from Jan 27, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 24, 2021 •
edited

Motivation for this change

required for the next TTS release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Jan 24, 2021
Merged
10 tasks
@ofborg ofborg bot requested a review from costrouc January 24, 2021 13:22
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 110688 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.scikit-tda
  • python39Packages.umap-learn
5 packages failed to build:
  • python37Packages.scikit-tda
  • python37Packages.umap-learn
  • python38Packages.scikit-tda
  • python38Packages.umap-learn
  • python39Packages.pynndescent
2 packages built:
  • python37Packages.pynndescent
  • python38Packages.pynndescent

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110688 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • python39Packages.scikit-tda
  • python39Packages.umap-learn
7 packages failed to build and are new build failures:
  • python37Packages.pynndescent: log was empty
  • python37Packages.scikit-tda: log was empty
  • python37Packages.umap-learn: log was empty
  • python38Packages.pynndescent: log was empty
  • python38Packages.scikit-tda: log was empty
  • python38Packages.umap-learn: log was empty
  • python39Packages.pynndescent: log was empty

Segfaults in sandbox

@Mic92
Copy link
Member Author

Mic92 commented Jan 24, 2021

@GrahamcOfBorg build python38Packages.umap-learn python37Packages.umap-learn

@Mic92 @SuperSandro2000
Update pkgs/development/python-modules/pynndescent/default.nix
3012c1c 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@Mic92
Copy link
Member Author

Mic92 commented Jan 24, 2021

@GrahamcOfBorg build python38Packages.umap-learn python37Packages.umap-learn

@Mic92
Copy link
Member Author

Mic92 commented Jan 24, 2021

Result of nixpkgs-review pr 110688 run on x86_64-linux 1
2 packages marked as broken and skipped:
5 packages failed to build:

* python37Packages.scikit-tda

* python37Packages.umap-learn

* python38Packages.scikit-tda

* python38Packages.umap-learn

* python39Packages.pynndescent

2 packages built:

* python37Packages.pynndescent

* python38Packages.pynndescent

Did you skipped building tensorflow here, I built it on my machine.

@SuperSandro2000
Copy link
Member

Did you skipped building tensorflow here, I built it on my machine.

Yes I do.

does not build all packages (e.g. lumo, tensorflow or pytorch).

@Mic92
Copy link
Member Author

Mic92 commented Jan 25, 2021

@GrahamcOfBorg build python38Packages.umap-learn

@Mic92 Mic92 merged commit b1c006f into NixOS:master Jan 27, 2021
@Mic92 Mic92 deleted the umap-learn branch January 27, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @SuperSandro2000