Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/chrony: add types #110686

Merged
merged 1 commit into from Jan 24, 2021
Merged

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

fixes in the list of #76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
Copy link
Contributor

lopsided98 commented Jan 31, 2021

initstepslew.threshold should be a float, not an int.

@Scriptkiddi
Copy link
Contributor Author

initstepslew.threshold should be a float, not an int.

Are you sure about that? The documentation is not really explicit on it, https://chrony.tuxfamily.org/doc/3.5/chrony.conf.html
It could be that you want that error correction to be less than a second but im not sure how often that is used in practice.
I prepared a commit just in case we want to allow floats, let me know what you think and i will open a pr if nessacery
helsinki-systems@fbaa76b

@lopsided98
Copy link
Contributor

I've been using 0.1 on one of my systems where I basically want it to step no matter what and chronyd's config parser accepts it. I have a very similar PR I've been testing and was planning to submit tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants