Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> 1.3.5 #110654

Merged
merged 1 commit into from Feb 17, 2021
Merged

[staging] perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> 1.3.5 #110654

merged 1 commit into from Feb 17, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 24, 2021 •
edited

Motivation for this change

https://metacpan.org/changes/release/SHAY/perl-5.32.1

dependencies:
perl-cross: arsv/perl-cross@4c55233 -> 1.3.5

Build:

  • linux x64
  • pkgCross aarch64
  • darwin x64 (big sur)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp marked this pull request as draft January 24, 2021 03:06
@ofborg ofborg bot requested a review from edolstra January 24, 2021 05:20
@stigtsp stigtsp marked this pull request as ready for review January 24, 2021 15:45
@stigtsp
Copy link
Member Author

stigtsp commented Jan 24, 2021

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl532
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl532
@GrahamcOfBorg build pkgsMusl.perl532
@GrahamcOfBorg build pkgsi686Linux.perl532
@GrahamcOfBorg build perl532

@stigtsp stigtsp changed the title perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> b6ebcff perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> 1.3.5 Jan 24, 2021
@stigtsp
Copy link
Member Author

stigtsp commented Jan 24, 2021

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl532
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl532

@aanderse
Copy link
Member

aanderse commented Feb 1, 2021

Thanks for your work on this @stigtsp.

zakame
zakame approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@zakame zakame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stigtsp
Copy link
Member Author

stigtsp commented Feb 8, 2021 •
edited

@ofborg build pkgsCross.aarch64-multiplatform.perldevelPackages.HTTPDaemon
@ofborg build hydra-unstable

@stigtsp
Copy link
Member Author

stigtsp commented Feb 8, 2021

@ofborg build pkgsCross.aarch64-multiplatform.perlPackages.HTTPDaemon

@stigtsp stigtsp mentioned this pull request Feb 8, 2021
Closed
6 tasks
@stigtsp stigtsp changed the title perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> 1.3.5 [staging] perl532: 5.32.0 -> 5.32.1, perl-cross: 4c55233 -> 1.3.5 Feb 8, 2021
@stigtsp
Copy link
Member Author

stigtsp commented Feb 15, 2021

This is imho ok to merge into staging

@stigtsp
Copy link
Member Author

stigtsp commented Feb 15, 2021

@ofborg build hydra-unstable

@stigtsp
Copy link
Member Author

stigtsp commented Feb 16, 2021

@ofborg build hydra-unstable

@stigtsp
Copy link
Member Author

stigtsp commented Feb 16, 2021

The hydra-unstable build failures seem unrelated to the perl bump.

I'll merge this soon, unless there are any objections @aanderse @adisbladis ?

SuperSandro2000
SuperSandro2000 approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM. We will know if the builds fail on staging or not.

@SuperSandro2000 SuperSandro2000 merged commit 0d489fc into NixOS:staging Feb 17, 2021
@aanderse
Copy link
Member

As always, thank you @stigtsp!

@bobrik bobrik mentioned this pull request Feb 19, 2021
Merged
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakame zakame zakame approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@aanderse aanderse Awaiting requested review from aanderse

@jonringer jonringer Awaiting requested review from jonringer

@alyssais alyssais Awaiting requested review from alyssais

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
1.severity: mass-rebuild 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stigtsp @aanderse @zakame @SuperSandro2000