Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'index' of null from testharness.js #27299

Closed
stephenmcgruer opened this issue Jan 24, 2021 · 2 comments · Fixed by #27308
Closed

TypeError: Cannot read property 'index' of null from testharness.js #27299

stephenmcgruer opened this issue Jan 24, 2021 · 2 comments · Fixed by #27308

Comments

@stephenmcgruer
Copy link
Contributor

934077a has caused a regression in native-io/rename_sync_failure_handling.tentative.https.any.worker.html:

$ ./wpt run --channel=dev chrome native-io/rename_sync_failure_handling.tentative.https.any.worker.html
Running 1 tests in web-platform-tests

  ▶ ERROR [expected OK] /native-io/rename_sync_failure_handling.tentative.https.any.worker.html
  │   → Uncaught TypeError: Cannot read property 'index' of null
  │ 
  │ TypeError: Cannot read property 'index' of null
  │     at RemoteContext.remote_done (https://web-platform.test:8443/resources/testharness.js:2632:50)
  └     at Worker.RemoteContext.message_handler (https://web-platform.test:8443/resources/testharness.js:2558:62)

  [1/1] No tests running.

It looks like this test has an assert in its setup method, and the code can't handle that:

        for (let assert of data.asserts) {
            var record = new AssertRecord();
            record.assert_name = assert.assert_name;
            record.args = assert.args;
            record.test = this.tests[assert.test.index];  <---- this line
            record.status = assert.status;
            record.stack = assert.stack;
            tests.asserts_run.push(record);
        }

cc @jgraham

@jgraham
Copy link
Contributor

jgraham commented Jan 26, 2021

This was fixed I believe.

@jgraham jgraham closed this as completed Jan 26, 2021
@stephenmcgruer
Copy link
Contributor Author

It was, in #27308 . Which had the magical 'fixes' text, but GitHub didn't link this and close it? Interesting...

Thanks for cleaning up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants