Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gbk decoder tests to be any.js #27300

Merged
merged 1 commit into from Jan 25, 2021

Conversation

lucacasonato
Copy link
Member

This changes the encoding/legacy-mb-schinese tests that do not require DOM (the decoding tests), to be .any.js tests so Deno can run them in it's WPT suite.

@annevk
Copy link
Member

annevk commented Jan 25, 2021

Do you have an idea as to why GitHub does not detect the first file as being renamed and slightly changed?

@annevk
Copy link
Member

annevk commented Jan 25, 2021

@achristensen07 fyi.

@annevk
Copy link
Member

annevk commented Jan 25, 2021

Maybe it's because you reformatted things slightly? Does your editor have a very short line length?

@lucacasonato
Copy link
Member Author

The script in HTML was all intended. I removed the 1 tab indent, which is what caused all of the changes I assume.

@annevk
Copy link
Member

annevk commented Jan 25, 2021

I guess ignore whitespace changes is not smart enough to revisit the question of whether to show it as a single file.

@annevk annevk merged commit 8f24193 into web-platform-tests:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants