Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solo5: add missing test dependencies #110674

Merged
merged 1 commit into from Jan 24, 2021
Merged

solo5: add missing test dependencies #110674

merged 1 commit into from Jan 24, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Tests are broken on master since solo5 uses getopt from util-linux and qemu-system-x86_64 from qemu in a test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehmry ehmry merged commit 2dd93a5 into NixOS:master Jan 24, 2021
@ehmry
Copy link
Contributor

ehmry commented Jan 24, 2021

Thanks! I didn't know we could run the non-linux tests.

@sternenseemann sternenseemann deleted the solo5-tests branch January 24, 2021 15:17
@sternenseemann sternenseemann restored the solo5-tests branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @ehmry @SuperSandro2000