Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] unbound: 1.11.0 -> 1.13.0 #110673

Merged
merged 2 commits into from Jan 24, 2021
Merged

[20.09] unbound: 1.11.0 -> 1.13.0 #110673

merged 2 commits into from Jan 24, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes #109225

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Jan 24, 2021
This was referenced Jan 24, 2021
Merged
Merged
@ofborg ofborg bot requested review from globin, ehmry and fpletz January 24, 2021 11:12
@mweinelt

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member

LGTM, but please rebase onto staging-20.09.

@dotlambda dotlambda changed the base branch from release-20.09 to staging-20.09 January 24, 2021 13:28
@ofborg ofborg bot requested a review from ehmry January 24, 2021 13:56
@mweinelt mweinelt added this to Ready in Staging (stable) Jan 24, 2021
@dotlambda dotlambda merged commit 2373e19 into NixOS:staging-20.09 Jan 24, 2021
Staging (stable) automation moved this from Ready to Done Jan 24, 2021
@dotlambda dotlambda deleted the unbound-1.13.0 branch January 17, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@adisbladis adisbladis Awaiting requested review from adisbladis

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@joachifm joachifm Awaiting requested review from joachifm

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@nbp nbp Awaiting requested review from nbp

@ttuegel ttuegel Awaiting requested review from ttuegel

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @mweinelt @ehmry