Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 2021.1.4 -> 2021.1.5 (and more) #110653

Merged
merged 4 commits into from Jan 25, 2021
Merged

home-assistant: 2021.1.4 -> 2021.1.5 (and more) #110653

merged 4 commits into from Jan 25, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/home-assistant/core/releases/tag/2021.1.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Jan 24, 2021 •
edited

fastapi fails thoroughly, because it relies on a feature removed from starlette in 0.14.1.

UJSONResponse was removed (this change was intended to be included in 0.14.0). Please see the documentation for how to implement responses using custom JSON serialization - #1074.

https://github.com/encode/starlette/releases/tag/0.14.1

@mweinelt mweinelt marked this pull request as draft January 24, 2021 02:52
@mweinelt
Copy link
Member Author

I'll look into this mess tomorrow.

@delroth
Copy link
Contributor

delroth commented Jan 24, 2021

LGTM for pyatmo bump.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110653 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python39Packages.pyatmo
  • python39Packages.pybotvac
  • python39Packages.starlette
2 packages failed to build and are new build failures:
12 packages built:
  • datasette (python38Packages.datasette)
  • home-assistant
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.pyatmo
  • python37Packages.pybotvac
  • python37Packages.starlette
  • python38Packages.asgi-csrf
  • python38Packages.pyatmo
  • python38Packages.pybotvac
  • python38Packages.starlette
  • python39Packages.asgi-csrf

@mweinelt mweinelt marked this pull request as ready for review January 24, 2021 12:59
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 110653 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.pyatmo
  • python39Packages.pybotvac
10 packages built:
  • datasette (python38Packages.datasette)
  • home-assistant
  • python37Packages.asgi-csrf
  • python37Packages.datasette
  • python37Packages.pyatmo
  • python37Packages.pybotvac
  • python38Packages.asgi-csrf
  • python38Packages.pyatmo
  • python38Packages.pybotvac
  • python39Packages.asgi-csrf

@SuperSandro2000 SuperSandro2000 merged commit 81db4e5 into NixOS:master Jan 25, 2021
@mweinelt mweinelt deleted the home-assistant branch January 25, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@risicle risicle Awaiting requested review from risicle

@dotlambda dotlambda Awaiting requested review from dotlambda

@wd15 wd15 Awaiting requested review from wd15

@delroth delroth Awaiting requested review from delroth

@Mic92 Mic92 Awaiting requested review from Mic92

@elseym elseym Awaiting requested review from elseym

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @delroth @SuperSandro2000