Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: 21.03 -> 21.05 #110666

Closed
wants to merge 1 commit into from
Closed

treewide: 21.03 -> 21.05 #110666

wants to merge 1 commit into from

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 24, 2021

Motivation for this change

Per RFC 80

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Why is this rebuilding:

aarch64-linux	dotnet-aspnetcore
aarch64-linux	dotnetCorePackages.aspnetcore_2_1

?

@siraben
Copy link
Member Author

siraben commented Jan 24, 2021

Why is this rebuilding:

aarch64-linux	dotnet-aspnetcore
aarch64-linux	dotnetCorePackages.aspnetcore_2_1

?

I have no idea. @jonringer could you take a look?

@zowoq
Copy link
Contributor

zowoq commented Jan 24, 2021

Looks like this is a dupe of #108899?

@siraben
Copy link
Member Author

siraben commented Jan 24, 2021

Looks like this is a dupe of #108899?

Oh it looks like, I wasn't aware of that PR.

@siraben siraben closed this Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@siraben @SuperSandro2000 @zowoq @dotlambda