Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libretro.play on gcc10 #110650

Closed
wants to merge 2 commits into from
Closed

Fix libretro.play on gcc10 #110650

wants to merge 2 commits into from

Conversation

matthewbauer
Copy link
Member

Update to latest play which supports gcc 10.

Also fix on macOS.

@matthewbauer matthewbauer mentioned this pull request Jan 24, 2021
Closed
@ofborg ofborg bot requested review from edwtjo, hrdinka and MP2E January 24, 2021 02:07
@austinbutler
Copy link
Member

Result of nixpkgs-review pr 110650 run on x86_64-linux 1

1 package built:
  • libretro.play

@austinbutler
Copy link
Member

This does fix the build, although when testing a game I get:

❯ retroarch
[CDROM] No sg devices found and sg kernel module is not loaded.
InitializeImpl
Error: GLX 1.2 and up are not supported
[1]    14889 segmentation fault (core dumped)  retroarch

Same game works fine on the last working nixpkgs version.

@stale
Copy link

stale bot commented Jul 23, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 23, 2021
@SuperSamus
Copy link
Contributor

I think that this can be closed now.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

@hrdinka hrdinka Awaiting requested review from hrdinka

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @austinbutler @SuperSamus @thiagokokada