treewide: fix double quoted strings in one-liners #110670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
requested review from
alyssais,
cdepillabout,
FRidh,
jonringer,
LnL7,
Mic92,
stigtsp and
zowoq
as code owners
ofborg
bot
added
6.topic: erlang
6.topic: GNOME
|
@SuperSandro2000 please run nixpkgs-review, bam has a hash change |
dotlambda
requested changes
Jan 24, 2021
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
|
siraben
force-pushed
the
double-quotes-fix
branch
from
0a96556
to
59f66c9
Compare
ofborg
bot
added
10.rebuild-linux: 0
and removed
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
|
do not commit, there are more bugs. |
This comment has been minimized.
This comment has been minimized.
siraben
force-pushed
the
double-quotes-fix
branch
from
59f66c9
to
30f566c
Compare
|
By the way, how are you pushing these patches? |
Signed-off-by: Ben Siraphob <bensiraphob@gmail.com>
siraben
force-pushed
the
double-quotes-fix
branch
from
30f566c
to
bc0d605
Compare
This comment has been minimized.
This comment has been minimized.
Oh I mean pushing the patches under NixOS/nixpkgs directly, do you email or run a command etc.? |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Prior discussion: #108099
Authored by @kvtb
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)