Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dulwich: 0.20.14 -> 0.20.15 #107452

Merged
merged 5 commits into from Jan 24, 2021
Merged

python3Packages.dulwich: 0.20.14 -> 0.20.15 #107452

merged 5 commits into from Jan 24, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Dec 23, 2020

Motivation for this change

Update to latest upstream release 0.20.15

Additionally:

  • Update the homepage entry to metadata
  • Add changelog entry to metadata
  • Clarify the licensing (see https://www.dulwich.io/ -> Licensing) or COPYING: 
    Dulwich may be used under the conditions of either of two licenses,
the Apache License (version 2.0 or later) or the GNU General Public License,
version 2.0 or later.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff changed the title python3Packages.dulwich: 0.20.14 -> 0.20.15 WIP: python3Packages.dulwich: 0.20.14 -> 0.20.15 Dec 23, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107452 run on x86_64-darwin 1

5 packages failed to build:
  • devpi-client
  • python37Packages.check-manifest
  • python38Packages.check-manifest
  • python39Packages.breezy
  • python39Packages.check-manifest
16 packages built:
  • breezy (python38Packages.breezy)
  • cabal2nix
  • dep2nix
  • klaus (python38Packages.klaus)
  • nix-prefetch-bzr
  • nix-prefetch-scripts
  • nix-update-source
  • python37Packages.breezy
  • python37Packages.dulwich
  • python37Packages.klaus
  • python38Packages.dulwich
  • python39Packages.dulwich
  • python39Packages.klaus
  • reno
  • vcstool
  • xandikos

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107452 run on x86_64-linux 1

3 packages failed to build:
  • devpi-client
  • python37Packages.check-manifest
  • python38Packages.check-manifest
20 packages built:
  • breezy (python38Packages.breezy)
  • cabal2nix
  • dep2nix
  • errbot
  • flatpak-builder
  • hydra-unstable
  • klaus (python38Packages.klaus)
  • nix-prefetch-bzr
  • nix-prefetch-scripts
  • nix-update-source
  • python37Packages.breezy
  • python37Packages.dulwich
  • python37Packages.klaus
  • python38Packages.dulwich
  • python39Packages.dulwich
  • python39Packages.klaus
  • rabbitvcs
  • reno
  • vcstool
  • xandikos

check-manifest

ERROR: Could not find a version that satisfies the requirement build>=0.1 (from check-manifest)

@fabaff
Copy link
Member Author

fabaff commented Dec 25, 2020

ERROR: Could not find a version that satisfies the requirement build>=0.1 (from check-manifest)

Thanks. Updates are included.

@ofborg ofborg bot requested a review from ruuda December 25, 2020 21:00
@fabaff fabaff changed the title WIP: python3Packages.dulwich: 0.20.14 -> 0.20.15 python3Packages.dulwich: 0.20.14 -> 0.20.15 Dec 25, 2020
ruuda
ruuda approved these changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes to the code look good to me. I haven’t tried to build these packages or dependencies.

@prusnak
Copy link
Member

prusnak commented Jan 2, 2021

@GrahamcOfBorg build python3Packages.build python3Packages.dulwich python3Packages.pep517 python3Packages.proto-plus

@prusnak
Copy link
Member

prusnak commented Jan 2, 2021 •
edited

Some of the updates causes a massive rebuild. Can you please split the PR into 4 different PRs so we can review/accept them individually?

The one (or ones) causing this massive rebuild will be targeted against the staging branch.

@fabaff
Copy link
Member Author

fabaff commented Jan 2, 2021

Break-outs:

@prusnak
Copy link
Member

prusnak commented Jan 2, 2021

Break-outs:

Can you please remove pep517 from the changeset to see whether the rebuild is smaller now?

@ofborg ofborg bot requested a review from ruuda January 4, 2021 11:43
@fabaff
Copy link
Member Author

fabaff commented Jan 4, 2021

Can you please remove pep517 from the changeset to see whether the rebuild is smaller now?

Removed

@prusnak
Copy link
Member

prusnak commented Jan 4, 2021

@GrahamcOfBorg build python3Packages.dulwich python3Packages.build python3Packages.proto-plus

@prusnak
Copy link
Member

prusnak commented Jan 4, 2021 •
edited

This PR is blocked until master is rebuilt with #108255 merged in from staging

SuperSandro2000
SuperSandro2000 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@fabaff
Copy link
Member Author

fabaff commented Jan 23, 2021

Updated commit messages to match the comment in another PR.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107452 run on x86_64-linux 1

23 packages built:
  • breezy (python38Packages.breezy)
  • cabal2nix
  • dep2nix
  • devpi-client
  • errbot
  • flatpak-builder
  • hydra-unstable
  • klaus (python38Packages.klaus)
  • nix-prefetch-bzr
  • nix-prefetch-scripts
  • nix-update-source
  • python37Packages.breezy
  • python37Packages.check-manifest
  • python37Packages.dulwich
  • python37Packages.klaus
  • python38Packages.check-manifest
  • python38Packages.dulwich
  • python39Packages.dulwich
  • python39Packages.klaus
  • rabbitvcs
  • reno
  • vcstool
  • xandikos

jonringer
jonringer approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 107452 run on x86_64-linux 1

23 packages built:
  • breezy (python38Packages.breezy)
  • cabal2nix
  • dep2nix
  • devpi-client
  • errbot
  • flatpak-builder
  • hydra-unstable
  • klaus (python38Packages.klaus)
  • nix-prefetch-bzr
  • nix-prefetch-scripts
  • nix-update-source
  • python37Packages.breezy
  • python37Packages.check-manifest
  • python37Packages.dulwich
  • python37Packages.klaus
  • python38Packages.check-manifest
  • python38Packages.dulwich
  • python39Packages.dulwich
  • python39Packages.klaus
  • rabbitvcs
  • reno
  • vcstool
  • xandikos

@jonringer jonringer merged commit c846241 into NixOS:master Jan 24, 2021
@fabaff fabaff deleted the dulwich branch January 24, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@ruuda ruuda Awaiting requested review from ruuda

Assignees
No one assigned
Labels
2.status: blocked by pr/issue 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabaff @SuperSandro2000 @prusnak @ruuda @jonringer