Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/build-support: stdenv.lib -> lib #110655

Merged
merged 1 commit into from Jan 25, 2021
Merged

pkgs/build-support: stdenv.lib -> lib #110655

merged 1 commit into from Jan 25, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 24, 2021

Motivation for this change

Part of #108938

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Profpatsch
Profpatsch approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, haven’t tried evaluating.

@siraben siraben force-pushed the build-support-stdenv-lib branch 2 times, most recently from 04fc5ad to 1abd232 Compare January 25, 2021 02:03
cole-h
cole-h reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits:

pkgs/build-support/release/ant-build.nix Outdated Show resolved Hide resolved
pkgs/build-support/cc-wrapper/default.nix Outdated Show resolved Hide resolved
pkgs/build-support/bintools-wrapper/default.nix Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, ofborg is green and a local hydra-eval-jobs is green. Thanks!

@cole-h cole-h merged commit aa8868c into NixOS:master Jan 25, 2021
@siraben siraben deleted the build-support-stdenv-lib branch January 25, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

@cole-h cole-h cole-h approved these changes

@andir andir Awaiting requested review from andir

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@Lassulus Lassulus Awaiting requested review from Lassulus

@roberth roberth Awaiting requested review from roberth

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @Profpatsch @cole-h