Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-not-found: fix zsh exit code #110676

Merged
merged 1 commit into from Jan 24, 2021
Merged

Conversation

sheenobu
Copy link
Contributor

Motivation for this change

Fixes #78568 . Found this separately and then found a bug report that already existed. This change makes zsh
mirror the bash version of this function in the same file.

Bad behavior:

talos nixpkgs % zsh -i -f -c 'd; echo $?'
zsh:1: command not found: d
127
talos nixpkgs % zsh -i -c 'd; echo $?' 
d: command not found
0

good behavior:

talos ~ % zsh -i -f -c 'd; echo $?' 
zsh:1: command not found: d
127
talos ~ % zsh -i -c 'd; echo $?'    
d: command not found
127
talos ~ % 
Things done

i only really tested by dropping the new function into my local zshrc.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in zsh with command-not-found, missing programs return null error
2 participants