Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.caqti: init at 1.3.0 #110657

Closed
wants to merge 4 commits into from
Closed

ocamlPackages.caqti: init at 1.3.0 #110657

wants to merge 4 commits into from

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Jan 24, 2021

Motivation for this change

Package the OCaml caqti library, a library for monadic cooperative-threaded access to various relational databases. I added myself as maintainer, although I don't have much experience maintaining such packages. If the relevant OCaml package reviewers would be willing/prefer to maintain these packages, I'm happy to accommodate.

I also tested these packages by building some personal projects that depend on caqti (https://github.com/bcc32/watch-later), so I can validate that at least caqti-async+caqti-driver-sqlite3 works fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcc32 bcc32 changed the title ocamlPackages.caqti ocamlPackages.caqti: init at 1.3.0 Jan 24, 2021
vbgl
vbgl requested changes Jan 24, 2021
View reviewed changes
pkgs/top-level/ocaml-packages.nix Outdated Show resolved Hide resolved
pkgs/development/ocaml-modules/postgresql/default.nix Outdated Show resolved Hide resolved
@bcc32
Copy link
Contributor Author

bcc32 commented Jan 24, 2021

Thanks for the review. I fixed up the comments, plus made some corrections to ocamlPackages.mariadb.

@vbgl
Copy link
Contributor

vbgl commented Jan 30, 2021

Merged as 1b6764d

@vbgl vbgl closed this Jan 30, 2021
@bcc32 bcc32 deleted the ocaml-caqti branch January 30, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@vbgl vbgl vbgl approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcc32 @vbgl @SuperSandro2000