[Gecko Bug 1691397] Intrinsic sizes that depend on percentage-sized abspos ancestors should account for containing-block padding correctly. #27779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld account for containing-block padding correctly. Abspos boxes resolve against the pading box, and we were failing to increase the percentage basis in that case if box-sizing was content-box. This is partially the cause of bug 1691374. Differential Revision: https://phabricator.services.mozilla.com/D104389 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1691397 gecko-commit: 83d93b876225b37ec0a8afd837eeb939fc0e4ae3 gecko-reviewers: layout-reviewers, mats
wpt-pr-bot
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abspos boxes resolve against the pading box, and we were failing to
increase the percentage basis in that case if box-sizing was
content-box.
This is partially the cause of bug 1691374.
Differential Revision: https://phabricator.services.mozilla.com/D104389
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1691397
gecko-commit: 83d93b876225b37ec0a8afd837eeb939fc0e4ae3
gecko-reviewers: layout-reviewers, mats